Skip to content

gh-129987: Selectively re-enable SLP autovectorization of _PyEval_EvalFrameDefault #132530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2025
Merged

gh-129987: Selectively re-enable SLP autovectorization of _PyEval_EvalFrameDefault #132530

merged 2 commits into from
Apr 15, 2025

Conversation

Yhg1s
Copy link
Member

@Yhg1s Yhg1s commented Apr 14, 2025 •
edited by bedevere-app bot
Loading

Only disable SLP autovectorization of _PyEval_EvalFrameDefault on newer GCCs, as the optimization bug seems to exist only on GCC 12 and later, and before GCC 9 disabling the optimization has a dramatic performance impact.

@Yhg1s
Only disable SLP autovectorization of _PyEval_EvalFrameDefault on n…
087f134 
…ewer

GCCs, as the optimization bug seems to exist only on GCC 12 and later, and
before GCC 9 disabling the optimization has a dramatic performance impact.
@Yhg1s Yhg1s requested a review from markshannon as a code owner April 14, 2025 21:02
@bedevere-app bedevere-app bot mentioned this pull request Apr 14, 2025
Closed
@Yhg1s Yhg1s requested review from mpage and removed request for markshannon April 14, 2025 21:07
mpage
mpage approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@mpage mpage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the thorough investigation!

@Yhg1s
Copy link
Member Author

Yhg1s commented Apr 15, 2025

For the record, I've run rerun the benchmarks on GCCs 7-15 with this change to verify it fixes the performance drop on old GCCs and doesn't affect new GCCs.

@Yhg1s Yhg1s enabled auto-merge (squash) April 15, 2025 09:16
@Yhg1s Yhg1s merged commit c66ffcf into python:main Apr 15, 2025
47 checks passed
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD14 3.x (tier-3) has failed when building commit c66ffcf.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1232/builds/5335) and take a look at the build logs.
  4. Check if the failure is related to this commit (c66ffcf) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1232/builds/5335

Failed tests:

  • test_interpreters

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/threading.py", line 1079, in _bootstrap_inner
    self._context.run(self.run)
    ~~~~~~~~~~~~~~~~~^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/threading.py", line 1021, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/test_interpreters/test_stress.py", line 30, in task
    interp = interpreters.create()
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/support/interpreters/__init__.py", line 76, in create
    id = _interpreters.create(reqrefs=True)
interpreters.InterpreterError: interpreter creation failed
k


Traceback (most recent call last):
  File "<frozen getpath>", line 358, in <module>
ValueError: embedded null byte
Warning -- Uncaught thread exception: InterpreterError
Exception in thread Thread-177 (task):
RuntimeError: error evaluating path

@Yhg1s
Copy link
Member Author

Yhg1s commented Apr 15, 2025

(Buildbot error is noise; it's been failing like that for ages.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesamesam thesamesam thesamesam left review comments

@mpage mpage mpage approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yhg1s @bedevere-bot @mpage @thesamesam